Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable thread backend for all Alpaka builds #643

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

stephenswat
Copy link
Member

Currently, the serial CPU backend is enabled in Alpaka only if you download Alpaka using FetchContent. When using a preinstalled version of Alpaka, the default backend is not correctly set. In this PR, I move the default backend configuration from a file which is only loaded for FetchContent usage to the main CMakeLists.txt file, allowing it to be used in all builds.

@stephenswat stephenswat added bug Something isn't working build This relates to the build system alpaka Changes related to Alpaka labels Jul 17, 2024
@stephenswat stephenswat requested a review from StewMH July 17, 2024 08:22
@stephenswat
Copy link
Member Author

@CrossR I can't seem to ask you for a review, but could you please give a green light?

@stephenswat stephenswat force-pushed the alpaka/installed_backend branch from 0ca5000 to a294974 Compare July 17, 2024 09:20
@stephenswat stephenswat changed the title Enable serial backend for all Alpaka builds Enable thread backend for all Alpaka builds Jul 17, 2024
Currently, the serial CPU backend is enabled in Alpaka only if you
download Alpaka using FetchContent. When using a preinstalled version of
Alpaka, the default backend is not correctly set. In this PR, I move the
default backend configuration from a file which is only loaded for
FetchContent usage to the main CMakeLists.txt file, allowing it to be
used in all builds.
@stephenswat stephenswat force-pushed the alpaka/installed_backend branch from a294974 to 3388c3b Compare July 17, 2024 09:20
@stephenswat
Copy link
Member Author

I also moved from the serial backend to the std::thread backend, as the serial backend doesn't work with the CCA code.

Copy link
Contributor

@StewMH StewMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@stephenswat stephenswat merged commit a61b55d into acts-project:main Jul 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpaka Changes related to Alpaka bug Something isn't working build This relates to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants